⚡ Sangsakala Proxy 🏠 Home
Skip to content

Safeguard AF_ALG control and send buffers - #9638

Open
youknowdot wants to merge 2 commits into
RustPython:mainfrom
youknowdot:fix/af-alg-control-buffer-20261103
Open

youknowdot wants to merge 2 commits into
RustPython:mainfrom
youknowdot:fix/af-alg-control-buffer-20261103

Conversation

@youknowdot

@youknowdot youknowdot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Build AF_ALG sendmsg control messages in storage aligned for cmsghdr, with all exposed bytes initialized. Compute message lengths, padding, total size and rounded allocation size with checked arithmetic before writing, so oversized IVs cannot be truncated to a smaller CMSG length followed by a copy using the original size. Allocate the control buffer once and report allocation/size errors rather than relying on unchecked growth. Validate the IV descriptor length before copying, and use the existing unlocked snapshot strategy for payloads across blocking sends.

This change is scoped to the AF_ALG host helper. Generic ancillary packing/parsing, argument conversion, iovec behavior and the existing difference from CPython's padded IV cmsg_len remain unchanged. Size/allocation errors are I/O errors here, not a claim of exact CPython exception parity. The wrapper validates the IV length before its existing copy; valid but very large IVs can still require a large allocation. Mutable and non-bytes payloads are copied once, which changes concurrent mutation visibility and adds allocation/MemoryError cost; immutable bytes keep the existing borrowed fast path. Existing argument validation, IV handling, binder behavior, and the shared snapshot helper's error path are not claimed fully CPython-compatible.

Validation

  • Independently source-reviewed Linux CMSG layout, alignment, initialization, checked size arithmetic including 32-bit rounded allocation, ownership and lifetime through the syscall.
  • rustfmt, git diff --check and normal repository hooks passed.
  • No local RustPython build, runtime test, benchmark, or dedicated oversized-IV test was run. Hosted CI is required. Existing test_socket.LinuxKernelCryptoAPI AES tests exercise this path only when AF_ALG accept and the relevant kernel algorithms work; their existing expected-failure markers are unchanged. The separate accept change is Fix accepting Linux AF_ALG sockets #9637, and neither PR requires a stacked base.

Assisted-by: OpenAI Codex:model version not exposed
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 39 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 18fc82b and 0896c0e.

Files selected for processing: 2
  • crates/host_env/src/socket.rs
  • crates/stdlib/src/socket.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Assisted-by: OpenAI Codex:model version not exposed
@youknowdot youknowdot changed the title Bound and align AF_ALG control messages Safeguard AF_ALG control and send buffers Nov 3, 2026
@youknowone
youknowone marked this pull request as ready for review November 4, 2026 01:23
@youknowone
youknowone marked this pull request as ready for review November 4, 2026 01:23
@youknowone
youknowone enabled auto-merge (squash) November 4, 2026 01:23
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T01:27:47.841563Z 0896c0e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants