Repository navigation
Safeguard AF_ALG control and send buffers - #9638
Open
youknowdot wants to merge 2 commits into
Open
youknowdot wants to merge 2 commits into
youknowdot wants to merge 2 commits into
Conversation
Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This was referenced Nov 3, 2026
Assisted-by: OpenAI Codex:model version not exposed
youknowone
approved these changes
Nov 4, 2026
youknowone
marked this pull request as ready for review
November 4, 2026 01:23
youknowone
marked this pull request as ready for review
November 4, 2026 01:23
youknowone
enabled auto-merge (squash)
November 4, 2026 01:23
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build AF_ALG
sendmsgcontrol messages in storage aligned forcmsghdr, with all exposed bytes initialized. Compute message lengths, padding, total size and rounded allocation size with checked arithmetic before writing, so oversized IVs cannot be truncated to a smaller CMSG length followed by a copy using the original size. Allocate the control buffer once and report allocation/size errors rather than relying on unchecked growth. Validate the IV descriptor length before copying, and use the existing unlocked snapshot strategy for payloads across blocking sends.This change is scoped to the AF_ALG host helper. Generic ancillary packing/parsing, argument conversion, iovec behavior and the existing difference from CPython's padded IV
cmsg_lenremain unchanged. Size/allocation errors are I/O errors here, not a claim of exact CPython exception parity. The wrapper validates the IV length before its existing copy; valid but very large IVs can still require a large allocation. Mutable and non-bytes payloads are copied once, which changes concurrent mutation visibility and adds allocation/MemoryError cost; immutable bytes keep the existing borrowed fast path. Existing argument validation, IV handling, binder behavior, and the shared snapshot helper's error path are not claimed fully CPython-compatible.Validation
rustfmt,git diff --checkand normal repository hooks passed.test_socket.LinuxKernelCryptoAPIAES tests exercise this path only when AF_ALG accept and the relevant kernel algorithms work; their existing expected-failure markers are unchanged. The separate accept change is Fix accepting Linux AF_ALG sockets #9637, and neither PR requires a stacked base.