⚡ Sangsakala Proxy 🏠 Home
Skip to content

Safely parse unaligned ancillary messages - #9640

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:fix/ancillary-parse-safety-20261103
Nov 4, 2026
Merged

youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:fix/ancillary-parse-safety-20261103

Conversation

@youknowdot

Copy link
Copy Markdown
Contributor

Summary

Parse ancillary-message bytes without assuming the public input slice is aligned for cmsghdr. Read complete headers with unaligned loads and validate data-prefix, declared-length, available-byte and next-offset bounds before slicing or advancing. A truncated final payload is returned only up to the bytes available; malformed short headers terminate parsing rather than underflowing.

Preserve the relevant platform-specific next-header rules, including Solaris/illumos rounding, Linux musl/ohos and emscripten strict end boundaries, and Hurd's next-message fit check. For an unaligned slice, offsets are interpreted relative to the beginning of the supplied bytes. Traversal continues to use the existing i32-sized checked_cmsg_space bound.

This does not change the generic ancillary packer, whose alignment and ownership require separate work, and does not claim complete Python recvmsg diagnostics or arbitrary-platform runtime parity. #9638 separately addresses the AF_ALG send helper.

Validation

  • Independently source-reviewed libc 0.2.189 platform CMSG layouts and boundary rules, unaligned accesses, checked arithmetic, lifetimes, malformed inputs and test safety.
  • Added host-internal tests for unaligned headers, short/truncated and maximal declared lengths, zero-payload boundaries, and comparison against the platform CMSG_NXTHDR macro. These validate byte-buffer invariants, not Python API behavior.
  • rustfmt, git diff --check, and normal repository hooks passed. Source merge-tree with Safeguard AF_ALG control and send buffers #9638 was clean.
  • No local RustPython build or execution, no host-unit-test execution, and no cross-target runtime validation were performed. Hosted CI must validate compilation and tests; unsupported targets still need their own execution evidence.

Assisted-by: OpenAI Codex:model version not exposed
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 18fc82b and 3525e4d.

Files selected for processing: 1
  • crates/host_env/src/socket.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@codspeed

codspeed Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing youknowdot:fix/ancillary-parse-safety-20261103 (3525e4d) with main (18fc82b)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@youknowone
youknowone marked this pull request as ready for review November 4, 2026 01:27
@youknowone
youknowone enabled auto-merge (squash) November 4, 2026 01:27
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T01:35:19.023445Z 3525e4d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@youknowone
youknowone merged commit 134e624 into RustPython:main Nov 4, 2026
26 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants