Repository navigation
Fix except-star wrapper types and traceback - #9646
Merged
youknowone merged 2 commits intoNov 4, 2026
Merged
youknowone merged 2 commits into
youknowone merged 2 commits into
Conversation
Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 30 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
The wrapped naked exception traceback test passed twice in hosted Windows CI for the except-star correction. Remove only its obsolete expectedFailure marker using update_lib; preserve the inherited test body and C-only skip. Assisted-by: OpenAI Codex:model version not exposed
youknowone
approved these changes
Nov 4, 2026
youknowone
marked this pull request as ready for review
November 4, 2026 01:32
youknowone
enabled auto-merge (squash)
November 4, 2026 01:32
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
📦 Library DependenciesThe following Lib/ modules were modified. Here are their dependencies: [x] lib: cpython/Lib/traceback.py dependencies:
dependent tests: (178 tests)
Legend:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the builtin
BaseExceptionGroupconstructor for new except-star wrappers and combined raised groups. It selectsExceptionGroupfor ordinary exceptions and permits aBaseExceptionGroupwhen a child is aKeyboardInterrupt,SystemExit, or another non-ExceptionBaseException, as CPython 3.15 does.For a naked exception matched by
except*, give the new wrapper a traceback at the current handler instruction rather than copying the child's original traceback. The child keeps its original traceback.exception_group_matchdocuments that its caller must attach that handler traceback; the frame'sCHECK_EG_MATCHis the sole in-repository caller.This does not change the existing leaf-identity-based reraised-exception classification, malformed/no-location bytecode handling, or the separate subgroup derivation work in #9588. The extra group-type check is on the except-star matching path; no benchmark was run.
Validation
_PyEval_ExceptionGroupMatch,_PyExc_CreateExceptionGroup, and the VM's lasti, source location, traceback and frame-materialization conventions.rustfmt,git diff --check, and normal repository hooks passed. Source merge-trees were clean against Share exception group construction and filtering controls #9588, Drop replaced frame traces outside locks #9596 and Drop replaced exception and traceback fields outside locks #9600.test_traceback.test_exception_group_wrapped_nakedandtest_except_starcover related ordinary-exception behavior, but direct coverage for a naked non-ExceptionBaseException and mixed reraised groups was not found. Existing expected-failure markers are unchanged pending exact hosted CI evidence.