You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Add PyBuffer_FillContiguousStrides to the C API - #9667
Implements PyBuffer_FillContiguousStrides from #8156.
Summary by CodeRabbit
New Features
Added support for filling contiguous buffer strides in C and Fortran order. Unrecognized order values follow C-order behavior.
Strides are calculated from the item size and shape dimensions. Zero-sized dimensions are supported, and nonpositive dimension counts return without accessing buffer pointers.
No actionable comments were generated in the recent review.
Walkthrough
This change adds the exported PyBuffer_FillContiguousStrides function. For positive dimensions, it fills strides using wrapping multiplication. It traverses dimensions forward for order 'F' and backward for other order values. For nonpositive dimensions, it returns without accessing pointers.
Changes: Buffer strides
Layer / File(s)
Summary
Stride calculation and validation crates/capi/src/pybuffer.rs
Adds PyBuffer_FillContiguousStrides and tests C-order, Fortran-order, fallback-order, zero-sized dimensions, aliased pointers, and nonpositive dimensions.
The stride-filling implementation has no identified merge-blocking defect and is ready to merge subject to normal checks.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely identifies the main change: adding PyBuffer_FillContiguousStrides to the C API.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Reviewing files that changed from the base of the PR and between 8ab429b and c2cfa22.
Files selected for processing: 1
crates/capi/src/pybuffer.rs
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements PyBuffer_FillContiguousStrides from #8156.
Summary by CodeRabbit