Repository navigation
Preserve native script filenames through execution - #9688
Draft
youknowdot wants to merge 1 commit into
Draft
youknowdot wants to merge 1 commit into
youknowdot wants to merge 1 commit into
Conversation
Keep OS paths native until Python conversion and retain surrogate-bearing filenames across execution, diagnostics, and signal-safe tracebacks. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep native script paths lossless instead of requiring UTF-8 during command-line parsing and file execution.
OsString/Paththrough script arguments, absolute paths, working directories,sys.path[0], andPYTHONSTARTUP.__file__, retain them in nestedco_filename, and keep original filenames in compiler warnings and syntax-error attributes._imp, and signal-safe faulthandler output.This targets the Linux failure in
test_cmd_line_script.CmdLineTest.test_non_ascii. Its expected-failure marker remains until an actual RustPython pass is observed. No tests, assertions, or standard-library files are changed.Reference
Compared with CPython 3.15.0 script/startup execution, file execution, script-directory handling, and signal-safe ASCII traceback output.
Validation
cargo check --locked --offline -p rustpython -p rustpython-vm -p rustpython-stdlib --testspasses.cargo clippy --locked --offline -p rustpython -p rustpython-vm -p rustpython-stdlib --tests -- -D warningspasses.cargo check --locked --offline -p rustpython --no-default-features --lib --bin rustpythonpasses, with two existing unused-item warnings in unchangedsrc/main.rs.test_cmd_line_script.CmdLineTest.test_non_asciipasses on CPython 3.15.0.Native RustPython execution was not performed locally because the required runtime guard is unavailable. Full workspace/C-API runtime tests and cross-platform execution remain unverified. Existing general audit-event and SyntaxError.args-tuple gaps are outside this change.
AI assistance: implementation, reference comparison, and source review were assisted by OpenAI Codex; model version is not exposed.