Repository navigation
Snapshot startup filesystem encoding on Linux - #9689
Draft
youknowdot wants to merge 2 commits into
Draft
youknowdot wants to merge 2 commits into
youknowdot wants to merge 2 commits into
Conversation
Initialize the Linux CLI locale explicitly, snapshot filesystem conversion for bootstrap and subinterpreters, and propagate codec failures without panicking or leaking socket descriptors. Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Regenerate the Linux-only marker through update_lib using the two exact-head hosted CI unexpected-success observations. Preserve all other test code and platform handling. Assisted-by: dot:frontier-intelligence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This addresses the runtime cause behind the Linux
test_utf8_mode.UTF8ModeTests.test_cmd_lineexpected failure. No test code or decorators are changed because a RustPython runtime pass is not yet available.CPython reference
Compared against CPython v3.15.0:
Validation
cargo check -p rustpython --lib --bin rustpython.cargo clippy -p rustpython-host_env -p rustpython-vm -p rustpython-stdlib -p rustpython --lib --bin rustpython -- -D warnings.cargo check -p rustpython-vm --no-default-features --features compiler.test_cmd_lineandtest_filesystemencodingreference cases passed.The host-helper probe does not execute RustPython's VM or interpreter. Local RustPython runtime and aggregate workspace/C-API suites were not run because no verified runtime guard is available. This draft needs hosted CI and runtime review. Only the GNU Linux Rust target is installed; Windows/WASI call sites were source-reviewed but not cross-compiled.
Scope and integration
Non-Linux filesystem behavior is preserved. Non-GNU Linux supports existing native fast codecs and retains its previous UTF-8 behavior for wider CODESETs. This does not add arbitrary embedded filesystem-codec overrides, Windows legacy mbcs support, complete raw
-mparsing, or non-UTF-8 getpath configuration strings.VirtualMachine::fsdecodeand dependent Rust path-result helpers now returnPyResult; embedding callers must propagate errors.check_initializationlets embedded callers inspect startup failures without diagnostics or process exit.This overlaps #9688 (native script filenames). A disposable composition of current main
9d657b02e4, #9688 and this patch passedcargo check -p rustpython --lib --bin rustpythonafter resolving thecant_open_fileoverlap and propagating four additionalfsdecoderesults insrc/lib.rsandcrates/vm/src/vm/python_run.rs. Those merge-time adjustments are prepared separately; neither standalone branch includes the other PR.AI assistance
This is maintainer-directed Python 3.15 upgrade work. OpenAI Codex assisted with investigation, implementation, source review and validation. Model version was not exposed. No human runtime validation is claimed.