Repository navigation
Require callable write method for CSV writers - #9635
Draft
youknowdot wants to merge 1 commit into
Draft
youknowdot wants to merge 1 commit into
youknowdot wants to merge 1 commit into
Conversation
Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. CodeRabbit Verify
|
This was referenced Nov 3, 2026
youknowone
requested changes
Nov 4, 2026
| return Err(vm.new_type_error(r#"argument 1 must have a "write" method"#)); | ||
| }; | ||
| if !write.is_callable() { | ||
| return Err(vm.new_type_error(r#"argument 1 must have a "write" method"#)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Require
csv.writer's first argument to provide a callablewriteattribute. CPython rejects both an object that is itself callable but lackswriteand an object whosewriteattribute is not callable; the latter previously failed only on the firstwriterowcall in RustPython. Attribute lookup errors continue to propagate.This is scoped to the write-method check. Existing differences in argument binding and the timing of writer allocation are not addressed.
Validation
csv_writerand reproduced rejection of bare callables and non-callablewritevalues, as well as propagation of a property error.test_csvsuite.