Repository navigation
Align CSV dialect binding and validation with CPython 3.15 - #9684
Draft
youknowdot wants to merge 3 commits into
Draft
youknowdot wants to merge 3 commits into
youknowdot wants to merge 3 commits into
Conversation
Replace bespoke format-option parsing with shared derived binders, allow all nine positional Dialect options, and preserve the outer constructor's input handling before dialect callbacks. Match dialect validation order and diagnostics without changing the parser's string representation. Assisted-by: OpenAI Codex:model version not exposed
Assisted-by: OpenAI Codex:model version not exposed
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Keep surrogate-safe registry names alongside shared dialect binding and validation. Assisted-by: OpenAI Codex:model version not exposed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reference: CPython 3.15.0 CSV dialect construction and validation.
Validation
cargo check --locked --offline -j1 -p rustpython-host_env -p rustpython-vm -p rustpython-stdlib --features rustpython-stdlib/threadingpassed.-D warningsis no longer clean on this newer base; no warning suppression or unrelated baseline edits.This change does not address existing dialect identity or the parser/writer scalar-string limitation for lone surrogates. Shared binder errors may name Dialect where CPython uses an anonymous parser; no bespoke error formatter is added. The branch now includes main through
9c77b331a9e4, including #9636 and #9639. The import conflict retains both the shared binder types andPyStrRef; the cumulative diff from main remains confined to CSV (+83/-110). Related #9635 is not included.AI assistance: OpenAI Codex performed source comparison, implementation, reference probes and independent source review; model version was not exposed.