Repository navigation
Preserve surrogate code points in CSV dialect names - #9639
youknowone merged 1 commit into
Conversation
Assisted-by: OpenAI Codex:model version not exposed
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Merging this PR will not alter performance
Comparing Footnotes
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Store CSV dialect registry names as WTF-8 instead of requiring valid UTF-8. Python strings may contain lone surrogate code points; CPython accepts such names when registering, selecting, listing, and unregistering a dialect. Lookups borrow the string key and do not allocate a new key.
The existing registry is process-global and is not a Python dict. Its insertion order, key identity, and custom string-subclass or non-string hash/equality behavior remain outside this change. General WTF-8 representation limitations and support for surrogate characters in CSV data or dialect options are also not addressed.
This combines cleanly at file level with #9635 and #9636; no merge was performed.
Validation
test_csvsuite.